hfb_jysh/backend/internal/modules/distribution/announcement_test.go

package distribution

import (
	"context"
	"errors"
	"testing"

	"hfb_sys/backend/internal/model"
)

// TestSiteAnnouncementCRUDIsSiteScoped 验证站长自助公告只能读写本站数据：
// 列表/更新/删除/上下架都强制 distribution_site_id = 本站，跨站 ID 视为不存在。
func TestSiteAnnouncementCRUDIsSiteScoped(t *testing.T) {
	db := distributionTestDB(t)
	repo := NewRepository(db)
	ctx := context.Background()

	siteA, err := repo.CreateSite(ctx, CreateSiteRequest{
		SiteCode: "ann_site_a", SiteName: "公告站A", Domain: "ann-a.hfb.local",
	})
	if err != nil {
		t.Fatal(err)
	}
	siteB, err := repo.CreateSite(ctx, CreateSiteRequest{
		SiteCode: "ann_site_b", SiteName: "公告站B", Domain: "ann-b.hfb.local",
	})
	if err != nil {
		t.Fatal(err)
	}

	created, err := repo.CreateSiteAnnouncement(ctx, 0, siteA.ID, CreateSiteAnnouncementRequest{
		Title: "本站公告", Content: "内容", Category: "notice",
	})
	if err != nil {
		t.Fatalf("CreateSiteAnnouncement failed: %v", err)
	}
	if created.DistributionSiteID != siteA.ID || created.Status != "draft" {
		t.Fatalf("unexpected created announcement: %+v", created)
	}

	// 列表按站点隔离
	pageA, err := repo.ListSiteAnnouncements(ctx, 0, siteA.ID, "", 1, 20)
	if err != nil {
		t.Fatal(err)
	}
	if pageA.Total != 1 {
		t.Fatalf("A 站应有 1 条公告, got %d", pageA.Total)
	}
	pageB, err := repo.ListSiteAnnouncements(ctx, 0, siteB.ID, "", 1, 20)
	if err != nil {
		t.Fatal(err)
	}
	if pageB.Total != 0 {
		t.Fatalf("B 站不应看到 A 站公告, got %d", pageB.Total)
	}

	// 跨站更新/删除/上下架一律拒绝
	if _, err := repo.UpdateSiteAnnouncement(ctx, 0, siteB.ID, created.ID, UpdateSiteAnnouncementRequest{Title: "改"}); !errors.Is(err, ErrAnnouncementNotFound) {
		t.Fatalf("跨站更新应返回 ErrAnnouncementNotFound, got %v", err)
	}
	if err := repo.DeleteSiteAnnouncement(ctx, 0, siteB.ID, created.ID); !errors.Is(err, ErrAnnouncementNotFound) {
		t.Fatalf("跨站删除应返回 ErrAnnouncementNotFound, got %v", err)
	}
	if _, err := repo.UpdateSiteAnnouncementStatus(ctx, 0, siteB.ID, created.ID, "publish"); !errors.Is(err, ErrAnnouncementNotFound) {
		t.Fatalf("跨站发布应返回 ErrAnnouncementNotFound, got %v", err)
	}

	// 本站更新与发布
	updated, err := repo.UpdateSiteAnnouncement(ctx, 0, siteA.ID, created.ID, UpdateSiteAnnouncementRequest{
		Title: "本站公告（改）", Content: "新内容", Category: "rule", Priority: 5, IsPinned: true,
	})
	if err != nil {
		t.Fatalf("UpdateSiteAnnouncement failed: %v", err)
	}
	if updated.Title != "本站公告（改）" || updated.Category != "rule" || !updated.IsPinned || updated.Priority != 5 {
		t.Fatalf("unexpected updated announcement: %+v", updated)
	}
	published, err := repo.UpdateSiteAnnouncementStatus(ctx, 0, siteA.ID, created.ID, "publish")
	if err != nil {
		t.Fatalf("publish failed: %v", err)
	}
	if published.Status != "published" || published.PublishedAt == nil {
		t.Fatalf("发布后状态/时间不正确: %+v", published)
	}
	archived, err := repo.UpdateSiteAnnouncementStatus(ctx, 0, siteA.ID, created.ID, "archive")
	if err != nil {
		t.Fatalf("archive failed: %v", err)
	}
	if archived.Status != "archived" {
		t.Fatalf("归档后状态不正确: %+v", archived)
	}
	if _, err := repo.ListSiteAnnouncements(ctx, 0, siteA.ID, "archived", 1, 20); err != nil {
		t.Fatalf("按状态查询失败: %v", err)
	}
	if err := repo.DeleteSiteAnnouncement(ctx, 0, siteA.ID, created.ID); err != nil {
		t.Fatalf("本站删除失败: %v", err)
	}
}

// TestUpdateSiteBrandingAnnouncementMode 验证公告来源开关可保存并校验非法值。
func TestUpdateSiteBrandingAnnouncementMode(t *testing.T) {
	db := distributionTestDB(t)
	repo := NewRepository(db)
	ctx := context.Background()

	site, err := repo.CreateSite(ctx, CreateSiteRequest{
		SiteCode: "ann_mode_site", SiteName: "模式站", Domain: "ann-mode.hfb.local",
	})
	if err != nil {
		t.Fatal(err)
	}
	if site.AnnouncementMode != model.AnnouncementModeInherit {
		t.Fatalf("默认公告来源应为 inherit, got %q", site.AnnouncementMode)
	}

	ownOnly := model.AnnouncementModeOwnOnly
	updated, err := repo.UpdateSiteBranding(ctx, 0, site.ID, UpdateSiteBrandingRequest{AnnouncementMode: &ownOnly})
	if err != nil {
		t.Fatalf("切换公告来源失败: %v", err)
	}
	if updated.AnnouncementMode != model.AnnouncementModeOwnOnly {
		t.Fatalf("announcement_mode = %q, want own_only", updated.AnnouncementMode)
	}

	invalid := "whatever"
	if _, err := repo.UpdateSiteBranding(ctx, 0, site.ID, UpdateSiteBrandingRequest{AnnouncementMode: &invalid}); !errors.Is(err, ErrInvalidAnnouncementMode) {
		t.Fatalf("非法来源应返回 ErrInvalidAnnouncementMode, got %v", err)
	}

	// 读侧容错：库里历史非法值按 inherit 返回
	if err := db.Model(&model.DistributionSite{}).Where("id = ?", site.ID).
		Update("announcement_mode", "legacy_value").Error; err != nil {
		t.Fatal(err)
	}
	reloaded, err := repo.FindSite(ctx, 0, site.ID)
	if err != nil {
		t.Fatal(err)
	}
	if reloaded.AnnouncementMode != model.AnnouncementModeInherit {
		t.Fatalf("非法历史值应回落 inherit, got %q", reloaded.AnnouncementMode)
	}
}