fix(events): 撞唯一键是幂等命中,不该刷 WARNING + dump 整条 SQL

## 现象(用户从日志里发现的)

    WARNING | 写入账号事件失败(account=60 exchange):
    (1062, "Duplicate entry 'official_exchange:elite:60:20260120QYOOB_bag360:...'")
    [SQL: INSERT INTO account_events (...) VALUES (...)]
    [parameters: {...}]

## 分析:**不是 bug,是幂等机制在工作,但日志级别错了**

`emit()` 刻意**不做预检查**,直接 INSERT,靠 `source_ref` 的唯一索引去重;
撞了就 catch(SAVEPOINT 只回滚这一条)。所以:

- **数据是对的** —— 重复的被挡住,`exchange_events_added` 只计新写入的
- **日志是错的** —— 撞唯一键被当成异常打 WARNING,还把整条 SQL + 参数 dump 出来

而"撞唯一键"在这里是**预期内的正常情况**:一键查询会把斗鱼官方兑换记录补成事件,
同一个账号会被反复查询 —— 第二次开始每条记录都会撞。一次查询能刷几十屏,
既淹掉真日志、又让人以为出事了(用户就是因此来问的)。

## 修法

区分「唯一键冲突」与「真错误」:

- 确认是 **1062**(并带 `Duplicate entry` 字样)→ 降为 **DEBUG**,一句话说明"已存在,跳过"
- 其它完整性错误(如非空约束 1048)→ **仍然是 WARNING**

刻意**不把 IntegrityError 整个静音** —— 那会把真问题一起藏起来。
新增 `_is_duplicate_entry()` 只在两种信号都对上时才降级。

## 测试(+3)

- 重复写入返回 False,且**不产生**任何 "写入账号事件失败" 的 WARNING
  (用 loguru 的临时 sink 真的抓日志来断言,不是看代码)
- 重复写入不会写进第二条
- `_is_duplicate_entry` 只认 1062,1048(非空约束)仍然返回 False
This commit is contained in:
yml2213
2026-10-04 20:35:24 +08:00
parent b199428619
commit 631e33a4f6
2 changed files with 119 additions and 0 deletions
+90
View File
@@ -1371,3 +1371,93 @@ class TestOverviewWritesBindStatus:
assert self.account.role_bind_status == "bound"
assert self.account.esports_bind_status == "unknown", "推不出来应保持原值"
assert self.account.xpd_bind_status == "unknown"
class TestDuplicateEventIsQuiet:
"""撞唯一键 = 幂等命中,是**预期内的正常情况**,不该刷 WARNING。
踩过的坑:`emit()` 不做预检查、直接 INSERT,靠唯一索引去重;撞了就
打 WARNING 并把**整条 SQL + 参数**dump 出来。而一键查询会把官方兑换记录
补成事件、同一个账号会被反复查询 —— 于是每查一次就刷一片 WARNING:
WARNING | 写入账号事件失败(account=60 exchange):
(1062, "Duplicate entry 'official_exchange:elite:60:...' ...")
[SQL: INSERT INTO account_events (...) VALUES (...)]
[parameters: {...}]
数据没错(重复的被挡住了),但日志被淹、运维以为出事了(用户就是因此来问的)。
"""
def setup_method(self):
self.engine = get_test_engine()
self.session = make_test_session(self.engine)
self.user = User(username="dup-admin", password_hash="h", role="super_admin")
self.session.add(self.user)
self.session.flush()
self.account = Account(
username="dup-acc", password="p", email="d@e.com", email_password="ep"
)
self.session.add(self.account)
self.session.commit()
def teardown_method(self):
self.session.close()
def _emit_once(self):
from web.backend.services.account_events_service import emit
return emit(
self.session,
account_id=self.account.id,
event_type="exchange",
title="兑换 某商品",
category="business",
source="official_sync",
source_ref="official_exchange:elite:dup:commodity:20261001",
)
def test_duplicate_returns_false_without_warning(self):
from loguru import logger
assert self._emit_once() is True
self.session.commit()
warnings: list[str] = []
sink_id = logger.add(lambda msg: warnings.append(str(msg)), level="WARNING")
try:
assert self._emit_once() is False, "重复写入应返回 False"
finally:
logger.remove(sink_id)
assert not [w for w in warnings if "写入账号事件失败" in w], (
"撞唯一键是正常的幂等命中,不该打 WARNING(日志会被淹,且误导运维)"
)
def test_duplicate_does_not_write_twice(self):
from web.backend.services import account_events_service as svc
self._emit_once()
self.session.commit()
self._emit_once()
self.session.commit()
assert (
self.session.query(AccountEvent)
.filter(AccountEvent.event_type == svc.EVENT_EXCHANGE)
.count()
== 1
)
def test_duplicate_helper_only_matches_1062(self):
"""只有**确认**是唯一键冲突才降级;其它完整性错误仍要告警。"""
from web.backend.services.account_events_service import _is_duplicate_entry
class _Orig(Exception):
pass
dup = Exception("x")
dup.orig = _Orig(1062, "Duplicate entry 'a' for key 'k'") # type: ignore[attr-defined]
assert _is_duplicate_entry(dup) is True
other = Exception("x")
other.orig = _Orig(1048, "Column 'a' cannot be null") # type: ignore[attr-defined]
assert _is_duplicate_entry(other) is False