生产是 MySQL 8、测试是 SQLite,两者的方言差异在本地完全测不出来。今天为此 付出了两次代价: 1. `ORDER BY ck_checked_at ASC NULLS FIRST` 在 SQLite 上完全正常,本地 258 条 全绿,一部署到生产第一次巡检就 1064 语法错误(MySQL 不支持 NULLS FIRST); 2. P1b 自动重登的结算复用调度器事务读取,在 SQLite 下看不出问题,但在 MySQL 的 REPEATABLE READ 下读到的是批次开始前的快照 —— 10 条实际成功的重登全部被记成 失败。SQLite 的读一致性与 MySQL 不同,这类问题跑一万遍也复现不出来。 改动: - 新增 tests/support/db.py:测试专用引擎/会话工具,连接串从 .env 读取, 默认指向独立的 douyu_login_test 库; - 新增 tests/conftest.py:会话级建好表结构,每个用例前后清空所有表做隔离; - 根 conftest.py 接管连接串设置:它在 pytest 收集阶段最先执行,在这里把 DATABASE_URL 指向测试库,应用模块首次 import 拿到就是 MySQL,不依赖任何 import 顺序(原先这里是 sqlite:// 兜底,改造后会变成「先建 SQLite engine 再打补丁换成 MySQL」,顺序一变就静默跑错库); - 21 个测试文件的 setup 样板统一改用共享测试引擎; - 两个迁移测试改为在临时库 douyu_login_mig_<随机> 上跑完整 alembic upgrade head, 跑完 drop —— 迁移脚本本身也终于在 MySQL 上被验证; - dev.sh 与 README 的过时说明一并更新(原先写着「不需要 MySQL / .env 配置」; 「测试各自建 SQLite 内存库」)。 安全与易用: - 测试库名与开发库同名时**直接拒绝运行**(clear_tables 会 DELETE 所有表, 一旦 TEST_MYSQL_DATABASE 被指到 douyu_login 就是数据灾难); - 连不上 MySQL 时给出可操作提示(先 ./dev.sh 起库 / 用 TEST_MYSQL_DATABASE 覆盖), 而不是抛一段 SQLAlchemy 原始堆栈。 验收: - 全量 301 条通过,连跑两次结果一致(隔离有效),耗时约 12.5 秒(原 SQLite 约 3.6 秒); - 单文件独立运行通过(不依赖全量执行顺序); - `grep -rn sqlite tests/ conftest.py` 已无实际用法; - **方言确实生效**:临时把一条查询改回 `NULLS FIRST`,13 条测试立刻变红(含运行期 失败),还原即恢复;这条由 test_generated_sql_is_mysql_compatible 长期守着。 代价(已在 README 与规划附录 C.2 记明):跑测试前必须先有 MySQL,pre-push 钩子 同理;CI 需要 service container。
239 lines
7.5 KiB
Python
239 lines
7.5 KiB
Python
"""充值审计日志的权限、查询和脱敏测试。"""
|
|
|
|
import json
|
|
|
|
import pytest
|
|
from fastapi import HTTPException
|
|
|
|
from tests.support.db import get_test_engine, make_test_session
|
|
from web.backend.models import Account, AuditLog, DouyuTask, User
|
|
from web.backend.routers.audit import list_audit_logs, require_super_admin
|
|
from web.backend.services.audit_service import record_audit
|
|
|
|
|
|
class TestAuditLog:
|
|
def setup_method(self):
|
|
self.engine = get_test_engine()
|
|
self.session = make_test_session(self.engine)
|
|
self.admin = User(username="admin", password_hash="hash", role="super_admin")
|
|
self.operator = User(
|
|
username="operator",
|
|
password_hash="hash",
|
|
role="operation",
|
|
custom_permissions=["audit:view"],
|
|
)
|
|
self.session.add_all([self.admin, self.operator])
|
|
self.session.commit()
|
|
|
|
def teardown_method(self):
|
|
self.session.close()
|
|
|
|
def test_only_super_admin_can_read_audit_logs(self):
|
|
with pytest.raises(HTTPException) as context:
|
|
require_super_admin(self.operator)
|
|
assert context.value.status_code == 403
|
|
assert require_super_admin(self.admin) is self.admin
|
|
|
|
def test_list_audit_logs_supports_pagination_and_result_filter(self):
|
|
for index in range(3):
|
|
record_audit(
|
|
self.session,
|
|
self.admin,
|
|
action="recharge:yyb:payment",
|
|
target=f"yyb_task:{index}",
|
|
detail={"task_id": index},
|
|
success=index != 1,
|
|
)
|
|
self.session.commit()
|
|
|
|
result = list_audit_logs(
|
|
page=1,
|
|
page_size=1,
|
|
username=None,
|
|
action="recharge:yyb:payment",
|
|
keyword=None,
|
|
success=True,
|
|
start_time=None,
|
|
end_time=None,
|
|
db=self.session,
|
|
_=self.admin,
|
|
)
|
|
|
|
assert result["total"] == 2
|
|
assert len(result["items"]) == 1
|
|
assert result["items"][0]["success"]
|
|
|
|
def test_audit_detail_masks_sensitive_fields(self):
|
|
record_audit(
|
|
self.session,
|
|
self.admin,
|
|
action="recharge:yyb:payment",
|
|
detail={
|
|
"token": "token-value",
|
|
"nested": {"cookie": "cookie-value"},
|
|
"order_id": "order-1",
|
|
},
|
|
)
|
|
self.session.commit()
|
|
|
|
entry = self.session.query(AuditLog).one()
|
|
detail = json.loads(entry.detail)
|
|
assert detail["token"] == "[已脱敏]"
|
|
assert detail["nested"]["cookie"] == "[已脱敏]"
|
|
assert detail["order_id"] == "order-1"
|
|
|
|
def test_old_douyu_recharge_log_is_enriched_with_account_identity(self):
|
|
account = Account(
|
|
username="douyu-login",
|
|
password="password",
|
|
email="mail@example.com",
|
|
email_password="mail-password",
|
|
uid="10001",
|
|
nickname="斗鱼昵称",
|
|
)
|
|
self.session.add(account)
|
|
self.session.commit()
|
|
self.session.add(
|
|
DouyuTask(
|
|
batch_id="batch-old",
|
|
account_id=account.id,
|
|
task_type="create_gold_qr",
|
|
handbook_scope="elite",
|
|
created_by=self.admin.id,
|
|
)
|
|
)
|
|
self.session.add(
|
|
AuditLog(
|
|
user_id=self.admin.id,
|
|
username=self.admin.username,
|
|
action="recharge:douyu:create",
|
|
target="douyu_batch:batch-old",
|
|
detail="{}",
|
|
success=True,
|
|
)
|
|
)
|
|
self.session.commit()
|
|
|
|
result = list_audit_logs(
|
|
page=1,
|
|
page_size=50,
|
|
username=None,
|
|
action=None,
|
|
keyword=None,
|
|
success=None,
|
|
start_time=None,
|
|
end_time=None,
|
|
db=self.session,
|
|
_=self.admin,
|
|
)
|
|
|
|
detail = json.loads(result["items"][0]["detail"])
|
|
assert detail["recharge_accounts"][0]["username"] == "douyu-login"
|
|
assert detail["recharge_accounts"][0]["douyu_uid"] == "10001"
|
|
assert detail["recharge_channel"] == "wechat_qr"
|
|
assert detail["payment_method"] == "微信扫码支付"
|
|
|
|
def test_audit_log_created_at_has_utc_timezone_suffix(self):
|
|
record_audit(
|
|
self.session,
|
|
self.admin,
|
|
action="recharge:yyb:payment",
|
|
target="yyb_task:1",
|
|
detail={"test": 1},
|
|
success=True,
|
|
)
|
|
self.session.commit()
|
|
|
|
result = list_audit_logs(
|
|
page=1,
|
|
page_size=10,
|
|
username=None,
|
|
action=None,
|
|
keyword=None,
|
|
success=None,
|
|
start_time=None,
|
|
end_time=None,
|
|
db=self.session,
|
|
_=self.admin,
|
|
)
|
|
|
|
created_at_str = result["items"][0]["created_at"]
|
|
assert created_at_str is not None
|
|
assert "+00:00" in created_at_str or created_at_str.endswith("Z")
|
|
|
|
def test_search_audit_logs_by_supplier_order_id_and_out_order_id(self):
|
|
account = Account(
|
|
username="test-user",
|
|
password="password",
|
|
email="test@example.com",
|
|
email_password="pwd",
|
|
uid="473705204",
|
|
nickname="用户29160540",
|
|
)
|
|
self.session.add(account)
|
|
self.session.commit()
|
|
|
|
task = DouyuTask(
|
|
batch_id="01dee6f6a272",
|
|
account_id=account.id,
|
|
task_type="create_gold_qr",
|
|
status="success",
|
|
supplier_out_order_id="DYGF01DEE6F6A272T99458",
|
|
result={
|
|
"recharge_channel": "supplier_api",
|
|
"out_order_id": "DYGF01DEE6F6A272T99458",
|
|
"buy_num": 280,
|
|
"supplier_order": {
|
|
"order_id": "200000124398920260912141221",
|
|
"order_status": 2,
|
|
},
|
|
},
|
|
created_by=self.admin.id,
|
|
)
|
|
self.session.add(task)
|
|
self.session.add(
|
|
AuditLog(
|
|
user_id=self.admin.id,
|
|
username=self.admin.username,
|
|
action="recharge:douyu:create",
|
|
target="douyu_batch:01dee6f6a272",
|
|
detail=json.dumps({"batch_id": "01dee6f6a272"}),
|
|
success=True,
|
|
)
|
|
)
|
|
self.session.commit()
|
|
|
|
# 1. 按供应商单号搜索
|
|
result_by_order_id = list_audit_logs(
|
|
page=1,
|
|
page_size=10,
|
|
username=None,
|
|
action=None,
|
|
keyword="200000124398920260912141221",
|
|
success=None,
|
|
start_time=None,
|
|
end_time=None,
|
|
db=self.session,
|
|
_=self.admin,
|
|
)
|
|
assert result_by_order_id["total"] == 1
|
|
detail = json.loads(result_by_order_id["items"][0]["detail"])
|
|
assert "200000124398920260912141221" in detail.get("supplier_order_ids", [])
|
|
assert "DYGF01DEE6F6A272T99458" in detail.get("supplier_out_order_ids", [])
|
|
assert detail.get("payment_method") == "API 直充支付"
|
|
|
|
# 2. 按外部单号搜索
|
|
result_by_out_id = list_audit_logs(
|
|
page=1,
|
|
page_size=10,
|
|
username=None,
|
|
action=None,
|
|
keyword="DYGF01DEE6F6A272T99458",
|
|
success=None,
|
|
start_time=None,
|
|
end_time=None,
|
|
db=self.session,
|
|
_=self.admin,
|
|
)
|
|
assert result_by_out_id["total"] == 1
|