完善掉线诊断并优化二维码加载
This commit is contained in:
@@ -124,9 +124,11 @@ func (h *Handler) Refresh(c *gin.Context) {
|
||||
}
|
||||
}
|
||||
refreshToken := strings.TrimSpace(req.RefreshToken)
|
||||
refreshTokenSource := "body"
|
||||
if refreshToken == "" {
|
||||
if cookieValue, err := c.Cookie(adminRefreshCookieName); err == nil {
|
||||
refreshToken = strings.TrimSpace(cookieValue)
|
||||
refreshTokenSource = "cookie"
|
||||
}
|
||||
}
|
||||
if refreshToken == "" {
|
||||
@@ -135,6 +137,8 @@ func (h *Handler) Refresh(c *gin.Context) {
|
||||
}
|
||||
tokens, err := h.service.Refresh(c.Request.Context(), refreshToken)
|
||||
if err != nil {
|
||||
reason, tokenVersion, currentVersion := middleware.AdminValidationFailure(err)
|
||||
middleware.RecordAdminAuthFailure(c, reason, refreshTokenSource, tokenVersion, currentVersion)
|
||||
writeAdminAuthError(c, err)
|
||||
return
|
||||
}
|
||||
|
||||
@@ -8,7 +8,9 @@ import (
|
||||
"strings"
|
||||
"time"
|
||||
|
||||
"hfb_sys/backend/internal/auditlog"
|
||||
"hfb_sys/backend/internal/captcha"
|
||||
"hfb_sys/backend/internal/logging"
|
||||
"hfb_sys/backend/internal/model"
|
||||
"hfb_sys/backend/internal/modules/auth"
|
||||
|
||||
@@ -92,21 +94,45 @@ func (r *Repository) Login(ctx context.Context, username string, password string
|
||||
func (r *Repository) FindActiveForToken(ctx context.Context, id uint64, tokenVersion int64) (*model.AdminUser, error) {
|
||||
var admin model.AdminUser
|
||||
if err := r.db.WithContext(ctx).First(&admin, id).Error; err != nil {
|
||||
if errors.Is(err, gorm.ErrRecordNotFound) {
|
||||
return nil, newTokenValidationError("admin_not_found", ErrAdminNotFound)
|
||||
}
|
||||
return nil, err
|
||||
}
|
||||
if admin.Status != "active" {
|
||||
return nil, ErrAdminDisabled
|
||||
return nil, newTokenValidationError("admin_disabled", ErrAdminDisabled)
|
||||
}
|
||||
if admin.TokenVersion <= 0 || admin.TokenVersion != tokenVersion {
|
||||
return nil, ErrInvalidRefreshToken
|
||||
return nil, newTokenVersionMismatchError(tokenVersion, admin.TokenVersion)
|
||||
}
|
||||
return &admin, nil
|
||||
}
|
||||
|
||||
func (r *Repository) RevokeTokens(ctx context.Context, adminID uint64) error {
|
||||
return r.db.WithContext(ctx).Model(&model.AdminUser{}).
|
||||
Where("id = ?", adminID).
|
||||
UpdateColumn("token_version", gorm.Expr("token_version + 1")).Error
|
||||
return r.db.WithContext(ctx).Transaction(func(tx *gorm.DB) error {
|
||||
if err := tx.Model(&model.AdminUser{}).
|
||||
Where("id = ?", adminID).
|
||||
UpdateColumn("token_version", gorm.Expr("token_version + 1")).Error; err != nil {
|
||||
return err
|
||||
}
|
||||
return appendTokenVersionAudit(tx, ctx, adminID, "logout")
|
||||
})
|
||||
}
|
||||
|
||||
func appendTokenVersionAudit(tx *gorm.DB, ctx context.Context, adminID uint64, reason string) error {
|
||||
bizID := adminID
|
||||
return auditlog.Append(tx, auditlog.Entry{
|
||||
ActorType: "admin",
|
||||
ActorID: logging.AdminIDFromContext(ctx),
|
||||
Action: "auth.token_version.bump",
|
||||
BizType: "admin_user",
|
||||
BizID: &bizID,
|
||||
Meta: auditlog.Meta{RequestID: logging.RequestIDFromContext(ctx)},
|
||||
Detail: map[string]any{
|
||||
"target_admin_id": adminID,
|
||||
"reason": reason,
|
||||
},
|
||||
})
|
||||
}
|
||||
|
||||
func (r *Repository) verifyCaptcha(ctx context.Context, captchaID string, captchaCode string) error {
|
||||
|
||||
@@ -14,8 +14,49 @@ var (
|
||||
ErrAdminDisabled = errors.New("admin disabled")
|
||||
ErrInvalidRefreshToken = errors.New("invalid refresh token")
|
||||
ErrLoginLocked = errors.New("login locked")
|
||||
ErrAdminNotFound = errors.New("admin not found")
|
||||
ErrTokenVersionMismatch = errors.New("admin token version mismatch")
|
||||
)
|
||||
|
||||
// TokenValidationError 为后台会话失败保留安全的诊断类别,响应仍使用统一文案。
|
||||
type TokenValidationError struct {
|
||||
Reason string
|
||||
TokenVersion int64
|
||||
CurrentVersion int64
|
||||
err error
|
||||
}
|
||||
|
||||
func (e *TokenValidationError) Error() string {
|
||||
return "admin token validation failed: " + e.Reason
|
||||
}
|
||||
|
||||
func (e *TokenValidationError) Unwrap() error {
|
||||
return e.err
|
||||
}
|
||||
|
||||
// AuthFailureReason 供中间件读取失败类别并写入结构化日志。
|
||||
func (e *TokenValidationError) AuthFailureReason() string {
|
||||
return e.Reason
|
||||
}
|
||||
|
||||
// AuthFailureVersions 返回令牌声明版本和数据库当前版本;非版本不匹配时均为 0。
|
||||
func (e *TokenValidationError) AuthFailureVersions() (int64, int64) {
|
||||
return e.TokenVersion, e.CurrentVersion
|
||||
}
|
||||
|
||||
func newTokenValidationError(reason string, err error) error {
|
||||
return &TokenValidationError{Reason: reason, err: err}
|
||||
}
|
||||
|
||||
func newTokenVersionMismatchError(tokenVersion, currentVersion int64) error {
|
||||
return &TokenValidationError{
|
||||
Reason: "token_version_mismatch",
|
||||
TokenVersion: tokenVersion,
|
||||
CurrentVersion: currentVersion,
|
||||
err: ErrTokenVersionMismatch,
|
||||
}
|
||||
}
|
||||
|
||||
type Service struct {
|
||||
repo *Repository
|
||||
jwt *auth.JWTManager
|
||||
@@ -31,7 +72,7 @@ func (s *Service) Refresh(ctx context.Context, refreshToken string) (*auth.Token
|
||||
}
|
||||
claims, err := s.jwt.ParseSubject(refreshToken, "refresh", "admin")
|
||||
if err != nil {
|
||||
return nil, ErrInvalidRefreshToken
|
||||
return nil, newTokenValidationError(auth.TokenFailureReason(err), ErrInvalidRefreshToken)
|
||||
}
|
||||
if s.repo == nil {
|
||||
return nil, ErrDependencyUnavailable
|
||||
@@ -41,7 +82,7 @@ func (s *Service) Refresh(ctx context.Context, refreshToken string) (*auth.Token
|
||||
if errors.Is(err, ErrAdminDisabled) {
|
||||
return nil, ErrAdminDisabled
|
||||
}
|
||||
return nil, ErrInvalidRefreshToken
|
||||
return nil, invalidRefreshTokenError(err)
|
||||
}
|
||||
pair, err := s.jwt.GenerateSubjectPairWithVersion(admin.ID, admin.Username, "admin", admin.TokenVersion)
|
||||
if err != nil {
|
||||
@@ -50,6 +91,21 @@ func (s *Service) Refresh(ctx context.Context, refreshToken string) (*auth.Token
|
||||
return &pair, nil
|
||||
}
|
||||
|
||||
func invalidRefreshTokenError(err error) error {
|
||||
reason := "invalid"
|
||||
var tokenErr *TokenValidationError
|
||||
if errors.As(err, &tokenErr) {
|
||||
reason = tokenErr.Reason
|
||||
return &TokenValidationError{
|
||||
Reason: reason,
|
||||
TokenVersion: tokenErr.TokenVersion,
|
||||
CurrentVersion: tokenErr.CurrentVersion,
|
||||
err: ErrInvalidRefreshToken,
|
||||
}
|
||||
}
|
||||
return newTokenValidationError(reason, ErrInvalidRefreshToken)
|
||||
}
|
||||
|
||||
func (s *Service) Captcha(ctx context.Context) (*CaptchaDTO, error) {
|
||||
if s.repo == nil {
|
||||
return nil, ErrDependencyUnavailable
|
||||
|
||||
@@ -5,6 +5,8 @@ import (
|
||||
"errors"
|
||||
"fmt"
|
||||
|
||||
"hfb_sys/backend/internal/auditlog"
|
||||
"hfb_sys/backend/internal/logging"
|
||||
"hfb_sys/backend/internal/model"
|
||||
"hfb_sys/backend/internal/modules/adminrole"
|
||||
|
||||
@@ -105,7 +107,7 @@ func (r *Repository) Update(ctx context.Context, id uint64, req UpdateAdminReque
|
||||
return nil, err
|
||||
}
|
||||
if req.Status != "" {
|
||||
if err := r.bumpTokenVersion(db, id); err != nil {
|
||||
if err := r.bumpTokenVersion(db, ctx, id, "admin_status_changed"); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
r.invalidatePermCache(ctx, id)
|
||||
@@ -158,7 +160,7 @@ func (r *Repository) AssignRoles(ctx context.Context, adminID uint64, roleIDs []
|
||||
return err
|
||||
}
|
||||
}
|
||||
return r.bumpTokenVersion(tx, adminID)
|
||||
return r.bumpTokenVersion(tx, ctx, adminID, "roles_changed")
|
||||
})
|
||||
if err != nil {
|
||||
return err
|
||||
@@ -186,7 +188,7 @@ func (r *Repository) ChangeOwnPassword(ctx context.Context, id uint64, oldPwd, n
|
||||
}).Error; err != nil {
|
||||
return err
|
||||
}
|
||||
return r.bumpTokenVersion(tx, id)
|
||||
return r.bumpTokenVersion(tx, ctx, id, "password_changed")
|
||||
})
|
||||
}
|
||||
|
||||
@@ -206,7 +208,7 @@ func (r *Repository) ResetPassword(ctx context.Context, id uint64, newPwd string
|
||||
}).Error; err != nil {
|
||||
return err
|
||||
}
|
||||
return r.bumpTokenVersion(tx, id)
|
||||
return r.bumpTokenVersion(tx, ctx, id, "password_reset")
|
||||
})
|
||||
}
|
||||
|
||||
@@ -259,10 +261,25 @@ func (r *Repository) invalidatePermCache(ctx context.Context, adminID uint64) {
|
||||
r.redis.Del(ctx, permCacheKey(adminID))
|
||||
}
|
||||
|
||||
func (r *Repository) bumpTokenVersion(db *gorm.DB, adminID uint64) error {
|
||||
return db.Model(&model.AdminUser{}).
|
||||
func (r *Repository) bumpTokenVersion(db *gorm.DB, ctx context.Context, adminID uint64, reason string) error {
|
||||
if err := db.Model(&model.AdminUser{}).
|
||||
Where("id = ?", adminID).
|
||||
UpdateColumn("token_version", gorm.Expr("token_version + 1")).Error
|
||||
UpdateColumn("token_version", gorm.Expr("token_version + 1")).Error; err != nil {
|
||||
return err
|
||||
}
|
||||
bizID := adminID
|
||||
return auditlog.Append(db, auditlog.Entry{
|
||||
ActorType: "admin",
|
||||
ActorID: logging.AdminIDFromContext(ctx),
|
||||
Action: "auth.token_version.bump",
|
||||
BizType: "admin_user",
|
||||
BizID: &bizID,
|
||||
Meta: auditlog.Meta{RequestID: logging.RequestIDFromContext(ctx)},
|
||||
Detail: map[string]any{
|
||||
"target_admin_id": adminID,
|
||||
"reason": reason,
|
||||
},
|
||||
})
|
||||
}
|
||||
|
||||
func permCacheKey(adminID uint64) string {
|
||||
|
||||
@@ -5,6 +5,8 @@ import (
|
||||
"errors"
|
||||
"fmt"
|
||||
|
||||
"hfb_sys/backend/internal/auditlog"
|
||||
"hfb_sys/backend/internal/logging"
|
||||
"hfb_sys/backend/internal/model"
|
||||
|
||||
"github.com/redis/go-redis/v9"
|
||||
@@ -125,7 +127,7 @@ func (r *Repository) Delete(ctx context.Context, id uint64) error {
|
||||
if err := tx.Delete(&model.Role{}, id).Error; err != nil {
|
||||
return err
|
||||
}
|
||||
return r.bumpAdminTokenVersions(tx, adminIDs)
|
||||
return r.bumpAdminTokenVersions(tx, ctx, adminIDs, "role_deleted")
|
||||
})
|
||||
if err != nil {
|
||||
return err
|
||||
@@ -161,7 +163,7 @@ func (r *Repository) AssignPermissions(ctx context.Context, roleID uint64, permI
|
||||
return err
|
||||
}
|
||||
}
|
||||
return r.bumpAdminTokenVersions(tx, adminIDs)
|
||||
return r.bumpAdminTokenVersions(tx, ctx, adminIDs, "role_permissions_changed")
|
||||
})
|
||||
if err != nil {
|
||||
return err
|
||||
@@ -218,13 +220,33 @@ func (r *Repository) adminIDsByRole(ctx context.Context, roleID uint64) ([]uint6
|
||||
return ids, err
|
||||
}
|
||||
|
||||
func (r *Repository) bumpAdminTokenVersions(tx *gorm.DB, adminIDs []uint64) error {
|
||||
func (r *Repository) bumpAdminTokenVersions(tx *gorm.DB, ctx context.Context, adminIDs []uint64, reason string) error {
|
||||
if len(adminIDs) == 0 {
|
||||
return nil
|
||||
}
|
||||
return tx.Model(&model.AdminUser{}).
|
||||
if err := tx.Model(&model.AdminUser{}).
|
||||
Where("id IN ?", adminIDs).
|
||||
UpdateColumn("token_version", gorm.Expr("token_version + 1")).Error
|
||||
UpdateColumn("token_version", gorm.Expr("token_version + 1")).Error; err != nil {
|
||||
return err
|
||||
}
|
||||
for _, adminID := range adminIDs {
|
||||
bizID := adminID
|
||||
if err := auditlog.Append(tx, auditlog.Entry{
|
||||
ActorType: "admin",
|
||||
ActorID: logging.AdminIDFromContext(ctx),
|
||||
Action: "auth.token_version.bump",
|
||||
BizType: "admin_user",
|
||||
BizID: &bizID,
|
||||
Meta: auditlog.Meta{RequestID: logging.RequestIDFromContext(ctx)},
|
||||
Detail: map[string]any{
|
||||
"target_admin_id": adminID,
|
||||
"reason": reason,
|
||||
},
|
||||
}); err != nil {
|
||||
return err
|
||||
}
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
func (r *Repository) invalidateAdminPermCaches(ctx context.Context, adminIDs []uint64) {
|
||||
|
||||
@@ -14,6 +14,34 @@ const (
|
||||
|
||||
var ErrInvalidToken = errors.New("invalid token")
|
||||
|
||||
// TokenValidationError 仅携带可安全记录的失败类别,不包含原始令牌或签名信息。
|
||||
type TokenValidationError struct {
|
||||
Reason string
|
||||
err error
|
||||
}
|
||||
|
||||
func (e *TokenValidationError) Error() string {
|
||||
return "token validation failed: " + e.Reason
|
||||
}
|
||||
|
||||
func (e *TokenValidationError) Unwrap() error {
|
||||
return e.err
|
||||
}
|
||||
|
||||
// AuthFailureReason 让 HTTP 鉴权层可在不依赖具体认证包的情况下读取失败类别。
|
||||
func (e *TokenValidationError) AuthFailureReason() string {
|
||||
return e.Reason
|
||||
}
|
||||
|
||||
// TokenFailureReason 返回适合写入日志的令牌校验失败类别。
|
||||
func TokenFailureReason(err error) string {
|
||||
var validationErr *TokenValidationError
|
||||
if errors.As(err, &validationErr) && validationErr.Reason != "" {
|
||||
return validationErr.Reason
|
||||
}
|
||||
return "invalid"
|
||||
}
|
||||
|
||||
type JWTManager struct {
|
||||
secret []byte
|
||||
accessTTL time.Duration
|
||||
@@ -79,22 +107,44 @@ func (m *JWTManager) ParseSubject(tokenText, expectedType string, expectedSubjec
|
||||
claims := &Claims{}
|
||||
token, err := jwt.ParseWithClaims(tokenText, claims, func(token *jwt.Token) (any, error) {
|
||||
if token.Method != m.signingMethod {
|
||||
return nil, ErrInvalidToken
|
||||
return nil, newTokenValidationError("signing_method")
|
||||
}
|
||||
return m.secret, nil
|
||||
})
|
||||
if err != nil || !token.Valid {
|
||||
return nil, ErrInvalidToken
|
||||
if err != nil {
|
||||
return nil, newTokenValidationError(jwtFailureReason(err))
|
||||
}
|
||||
if !token.Valid {
|
||||
return nil, newTokenValidationError("invalid")
|
||||
}
|
||||
if claims.TokenType != expectedType {
|
||||
return nil, ErrInvalidToken
|
||||
return nil, newTokenValidationError("token_type")
|
||||
}
|
||||
if expectedSubjectType != "" && claims.SubjectType != expectedSubjectType {
|
||||
return nil, ErrInvalidToken
|
||||
return nil, newTokenValidationError("subject_type")
|
||||
}
|
||||
return claims, nil
|
||||
}
|
||||
|
||||
func newTokenValidationError(reason string) error {
|
||||
return &TokenValidationError{Reason: reason, err: ErrInvalidToken}
|
||||
}
|
||||
|
||||
func jwtFailureReason(err error) string {
|
||||
switch {
|
||||
case errors.Is(err, jwt.ErrTokenExpired):
|
||||
return "expired"
|
||||
case errors.Is(err, jwt.ErrTokenSignatureInvalid):
|
||||
return "signature_invalid"
|
||||
case errors.Is(err, jwt.ErrTokenMalformed):
|
||||
return "malformed"
|
||||
case errors.Is(err, jwt.ErrTokenNotValidYet):
|
||||
return "not_valid_yet"
|
||||
default:
|
||||
return "invalid"
|
||||
}
|
||||
}
|
||||
|
||||
func (m *JWTManager) generate(userID uint64, subject string, subjectType string, tokenType string, tokenVersion int64, ttl time.Duration) (string, error) {
|
||||
now := time.Now()
|
||||
claims := Claims{
|
||||
|
||||
@@ -0,0 +1,62 @@
|
||||
package auth
|
||||
|
||||
import (
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
|
||||
func TestParseSubjectReportsSafeFailureReason(t *testing.T) {
|
||||
manager := NewJWTManager("test-jwt-secret-for-failure-reason")
|
||||
pair, err := manager.GenerateSubjectPairWithVersion(1, "admin", "admin", 1)
|
||||
if err != nil {
|
||||
t.Fatalf("GenerateSubjectPairWithVersion() error = %v", err)
|
||||
}
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
manager *JWTManager
|
||||
token string
|
||||
tokenType string
|
||||
want string
|
||||
}{
|
||||
{
|
||||
name: "签名不匹配",
|
||||
manager: NewJWTManager("another-jwt-secret-for-failure-reason"),
|
||||
token: pair.AccessToken,
|
||||
tokenType: "access",
|
||||
want: "signature_invalid",
|
||||
},
|
||||
{
|
||||
name: "令牌类型不匹配",
|
||||
manager: manager,
|
||||
token: pair.AccessToken,
|
||||
tokenType: "refresh",
|
||||
want: "token_type",
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
_, err := tt.manager.ParseSubject(tt.token, tt.tokenType, "admin")
|
||||
if err == nil {
|
||||
t.Fatal("ParseSubject() error = nil")
|
||||
}
|
||||
if got := TokenFailureReason(err); got != tt.want {
|
||||
t.Fatalf("TokenFailureReason() = %q, want %q", got, tt.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
t.Run("令牌已过期", func(t *testing.T) {
|
||||
expiredManager := NewJWTManager("test-jwt-secret-for-expired-token")
|
||||
expiredManager.accessTTL = -time.Minute
|
||||
expiredPair, err := expiredManager.GenerateSubjectPairWithVersion(1, "admin", "admin", 1)
|
||||
if err != nil {
|
||||
t.Fatalf("GenerateSubjectPairWithVersion() error = %v", err)
|
||||
}
|
||||
_, err = expiredManager.ParseSubject(expiredPair.AccessToken, "access", "admin")
|
||||
if got := TokenFailureReason(err); got != "expired" {
|
||||
t.Fatalf("TokenFailureReason() = %q, want %q", got, "expired")
|
||||
}
|
||||
})
|
||||
}
|
||||
Reference in New Issue
Block a user