删除钱包充值功能并消除重复入账风险

钱包充值为开发态测试功能(生产环境本就禁用),且支付回调存在重复入账风险:入账与标记 paid 两步非原子、wallet_ledger 去重无唯一索引、幂等键使用了可变的 ProviderOrderID。直接删除该功能从根本上消除风险。后端: - payment 移除 StartWalletRecharge/QueryWalletRecharge 及相关 handler/DTO/常量;confirmPaid 增加 OrderID 守卫;解除对 wallet 仓库的依赖 - wallet 移除 Recharge/ConfirmRechargeFromChannel 及相关定义 - 移除三条充值路由;adminfinance 财务统计口径只统计 order_pay - 清理充值相关测试用例前端: - 移除充值 API、WalletView 充值面板/弹窗、admin 充值标签与筛选 - 保留钱包余额、流水、提现等核心能力 go build/vet 与 vue-tsc typecheck 均通过。 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-14 02:45:46 +08:00
parent 3ef7705776
commit e8621728fd
23 changed files with 28 additions and 863 deletions
@@ -64,113 +64,6 @@ func TestRepositoryAccountCreatesAccountIfNotExists(t *testing.T) {
 	}
 }

-// TestRepositoryRechargeIncreasesAvailableBalance 测试充值增加可用余额
-func TestRepositoryRechargeIncreasesAvailableBalance(t *testing.T) {
-	db := setupTestDB(t)
-	defer cleanupTestDB(t, db)
-
-	repo := NewRepository(db)
-	ctx := context.Background()
-	userID := uint64(1002)
-
-	// 第一次充值
-	account, err := repo.Recharge(ctx, userID, 10000)
-	if err != nil {
-		t.Fatalf("Recharge() error = %v", err)
-	}
-	if account.AvailableBalanceCent != 10000 {
-		t.Fatalf("第一次充值后余额 = %d, want 10000", account.AvailableBalanceCent)
-	}
-
-	// 第二次充值
-	account, err = repo.Recharge(ctx, userID, 5000)
-	if err != nil {
-		t.Fatalf("Recharge() error = %v", err)
-	}
-	if account.AvailableBalanceCent != 15000 {
-		t.Fatalf("第二次充值后余额 = %d, want 15000", account.AvailableBalanceCent)
-	}
-
-	// 验证账本记录
-	ledger, err := repo.Ledger(ctx, userID, 1, 10)
-	if err != nil {
-		t.Fatalf("Ledger() error = %v", err)
-	}
-	if ledger.Total != 2 {
-		t.Fatalf("账本记录数 = %d, want 2", ledger.Total)
-	}
-}
-
-// TestRepositoryConfirmRechargeFromChannelIsIdempotent 测试渠道充值幂等性
-func TestRepositoryConfirmRechargeFromChannelIsIdempotent(t *testing.T) {
-	db := setupTestDB(t)
-	defer cleanupTestDB(t, db)
-
-	repo := NewRepository(db)
-	ctx := context.Background()
-	userID := uint64(1003)
-	bizNo := "PAY123456"
-	amount := int64(10000)
-
-	// 第一次确认充值
-	err := repo.ConfirmRechargeFromChannel(ctx, userID, bizNo, amount)
-	if err != nil {
-		t.Fatalf("第一次 ConfirmRechargeFromChannel() error = %v", err)
-	}
-
-	account, _ := repo.Account(ctx, userID)
-	if account.AvailableBalanceCent != amount {
-		t.Fatalf("第一次充值后余额 = %d, want %d", account.AvailableBalanceCent, amount)
-	}
-
-	// 第二次确认充值（相同 bizNo）应该幂等，不重复入账
-	err = repo.ConfirmRechargeFromChannel(ctx, userID, bizNo, amount)
-	if err != nil {
-		t.Fatalf("第二次 ConfirmRechargeFromChannel() error = %v", err)
-	}
-
-	account, _ = repo.Account(ctx, userID)
-	if account.AvailableBalanceCent != amount {
-		t.Fatalf("第二次充值后余额 = %d, want %d（应保持不变）", account.AvailableBalanceCent, amount)
-	}
-
-	// 验证只有一条账本记录
-	ledger, _ := repo.Ledger(ctx, userID, 1, 10)
-	if ledger.Total != 1 {
-		t.Fatalf("账本记录数 = %d, want 1（幂等）", ledger.Total)
-	}
-}
-
-// TestRepositoryConfirmRechargeFromChannelRejectsInvalidParams 测试参数验证
-func TestRepositoryConfirmRechargeFromChannelRejectsInvalidParams(t *testing.T) {
-	db := setupTestDB(t)
-	defer cleanupTestDB(t, db)
-
-	repo := NewRepository(db)
-
-	testCases := []struct {
-		name      string
-		userID    uint64
-		bizNo     string
-		amount    int64
-		wantError error
-	}{
-		{"userID 为 0", 0, "BIZ123", 1000, ErrInvalidAmount},
-		{"bizNo 为空", 1004, "", 1000, ErrInvalidAmount},
-		{"amount 为 0", 1004, "BIZ123", 0, ErrInvalidAmount},
-		{"amount 为负数", 1004, "BIZ123", -1000, ErrInvalidAmount},
-	}
-
-	for _, tc := range testCases {
-		t.Run(tc.name, func(t *testing.T) {
-			err := repo.ConfirmRechargeFromChannel(context.Background(), tc.userID, tc.bizNo, tc.amount)
-			if err != tc.wantError {
-				t.Fatalf("error = %v, want %v", err, tc.wantError)
-			}
-		})
-	}
-}
-
 // TestAppendEntriesUpdatesBalanceCorrectly 测试 AppendEntries 余额计算
 func TestAppendEntriesUpdatesBalanceCorrectly(t *testing.T) {
 	db := setupTestDB(t)